From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31588 invoked by alias); 21 Feb 2012 18:17:44 -0000 Received: (qmail 31580 invoked by uid 22791); 21 Feb 2012 18:17:42 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 21 Feb 2012 18:17:13 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1LIHDEB006306 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 21 Feb 2012 13:17:13 -0500 Received: from host2.jankratochvil.net (ovpn-116-21.ams2.redhat.com [10.36.116.21]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q1LIH86D008864 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 21 Feb 2012 13:17:11 -0500 Date: Tue, 21 Feb 2012 18:18:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: testsuite: prefix handling Message-ID: <20120221181708.GA2538@host2.jankratochvil.net> References: <20120217193546.10029.74207.stgit@hit-nxdomain.opendns.com> <20120217193648.10029.26589.stgit@hit-nxdomain.opendns.com> <87pqdd9pjs.fsf@fleche.redhat.com> <4F3EBEAC.1070805@redhat.com> <87k43l87vb.fsf@fleche.redhat.com> <4F43B6A5.3010900@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F43B6A5.3010900@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00440.txt.bz2 On Tue, 21 Feb 2012 16:22:13 +0100, Pedro Alves wrote: > {}'s is just tcl's list representation. So `lappend pf_prefix "something with spaces"' > will end up with {}'s in gdb.sum output. So I agree we should indeed treat > pf_prefix as a simple string. I followed rather a rule that the pf_prefix component must never contain a space. This way the resulting pf_prefix is a list and one can iterate it by each appended component / remove it etc. But I have never used it that way. Also maybe the non-spaced output is better to read, one easily sees the nested component; but maybe the opposite is true and one can just check ':'s, YMMV. with-libs: without-PIE: some test vs. with libs: without PIE: some test > Only a few tests weren't converted to use with_test_prefix by this > patch. Those are ones that I found that: As new testcase are in many cases created by copying existing ones the wrong still will be spreading in the future. Sure there are many cases of such leftover old styles in the GDB codebase. > WDYT? I would also prefer reindentation. Thanks, Jan