From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14193 invoked by alias); 21 Feb 2012 17:08:38 -0000 Received: (qmail 14182 invoked by uid 22791); 21 Feb 2012 17:08:37 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 21 Feb 2012 17:07:49 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5CA1E1C6A4B; Tue, 21 Feb 2012 12:07:48 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 7jUm9-r6teQG; Tue, 21 Feb 2012 12:07:48 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2599F1C69FB; Tue, 21 Feb 2012 12:07:48 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 4530A145615; Tue, 21 Feb 2012 09:07:40 -0800 (PST) Date: Tue, 21 Feb 2012 18:16:00 -0000 From: Joel Brobecker To: Tristan Gingold Cc: "gdb-patches@sourceware.org ml" Subject: Re: RFA: [Ada] extract known tasks array parameters from symbol table Message-ID: <20120221170740.GH2692@adacore.com> References: <7A06C670-A574-4AE4-A89C-2532671E5F64@adacore.com> <20120213161529.GE3474@adacore.com> <5F4AB963-E82C-4206-B479-E46311CDABB0@adacore.com> <20120216171547.GD14803@adacore.com> <20120217163434.GF14803@adacore.com> <54477479-8A1C-4EC2-BE78-E790828EDD5E@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54477479-8A1C-4EC2-BE78-E790828EDD5E@adacore.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00438.txt.bz2 > In fact it wasn't that good. Leads to crash in case the symbol was > LOC_UNRESOLVED. It is therefore better to use the minsymtab to get > the address. Here is the new version. Ah - Ugh! > 2012-02-13 Tristan Gingold > > * ada-tasks.c (struct ada_tasks_inferior_data): Add > known_tasks_element and known_tasks_length fields. > (read_known_tasks_array): Change argument type. Use pointer type > and number of elements from DATA. Adjust. > (read_known_tasks_list): Likewise. > (get_known_tasks_addr): Remove. > (ada_set_current_inferior_known_tasks_addr): Renamed to ... > (ada_tasks_inferior_data_sniffer): ... this. Use symtab for element > type and array length. Merge former get_known_tasks_addr code. This one looks good to me. Thanks! -- Joel