From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-88044-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21107 invoked by alias); 20 Feb 2012 20:54:01 -0000
Received: (qmail 21097 invoked by uid 22791); 20 Feb 2012 20:54:00 -0000
X-SWARE-Spam-Status: No, hits=-6.6 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 20 Feb 2012 20:53:40 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1KKreId031785	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Mon, 20 Feb 2012 15:53:40 -0500
Received: from host2.jankratochvil.net (ovpn-116-21.ams2.redhat.com [10.36.116.21])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q1KKrapM020515	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 20 Feb 2012 15:53:39 -0500
Date: Mon, 20 Feb 2012 21:04:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: FYI: fix some performance bugs with .gdb_index
Message-ID: <20120220205336.GB15256@host2.jankratochvil.net>
References: <87pqd9uthn.fsf@fleche.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87pqd9uthn.fsf@fleche.redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-02/txt/msg00416.txt.bz2

On Mon, 20 Feb 2012 21:42:28 +0100, Tom Tromey wrote:
> +      visited_found = htab_create_alloc (10,
> +					 htab_hash_pointer, htab_eq_pointer,
> +					 NULL, xcalloc, xfree);
[...]
> +      visited_not_found = htab_create_alloc (10,
> +					     htab_hash_pointer, htab_eq_pointer,
> +					     NULL, xcalloc, xfree);
[...]
> +  htab_t visited = htab_create_alloc (10, htab_hash_pointer, htab_eq_pointer,
> +				      NULL, xcalloc, xfree);

Just wouldn't be obstack + hashtab_obstack_allocate more appropriate here?


Thanks,
Jan