Re: testsuite: prefix handling

Jan Kratochvil
2012-02-21T18:17:44Z

On Tue, 21 Feb 2012 16:22:13 +0100, Pedro Alves wrote:
> {}'s is just tcl's list representation. So `lappend pf_prefix "something with spaces"'
> will end up with {}'s in gdb.sum output. So I agree we should indeed treat
> pf_prefix as a simple string.

I followed rather a rule that the pf_prefix component must never contain
a space. This way the resulting pf_prefix is a list and one can iterate it by
each appended component / remove it etc. But I have never used it that way.

Also maybe the non-spaced output is better to read, one easily sees the nested
component; but maybe the opposite is true and one can just check ':'s, YMMV.
with-libs: without-PIE: some test
vs.
with libs: without PIE: some test

> Only a few tests weren't converted to use with_test_prefix by this
> patch. Those are ones that I found that:

As new testcase are in many cases created by copying existing ones the wrong
still will be spreading in the future. Sure there are many cases of such
leftover old styles in the GDB codebase.

> WDYT?

I would also prefer reindentation.

Thanks,
Jan