Re: [PATCH 1/2] gdb.threads/attach-into-signal.exp: cleanup

Tom Tromey
2012-02-17T20:24:28Z

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> - build different executable files for the non-threaded and threaded
Pedro> cases. This was my motivation. I wanted to test the non-threaded
Pedro> case manually, but the threaded variant always clobbered the
Pedro> non-threaded executable.

I think this ought to be a general rule. We need exceptions to it for
some executable-changed cases, but I think in general different tests
should build different executables, because this makes it easier to do
additional checking by hand.

Pedro> + set save_pf_prefix $pf_prefix
Pedro> + lappend pf_prefix "$threadtype:"

I think this should be append rather than lappend, as pf_prefix is just
a string, not a list.

Pedro> if [get_compiler_info ${binfile}] {
Pedro> + set pf_prefix $save_pf_prefix
Pedro> return -1
Pedro> }

I've occasionally wanted a wrapper like 'with_pf_prefix $whatever { body }'.
But not enough to write it :)

Tom