From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7173 invoked by alias); 16 Feb 2012 00:13:42 -0000 Received: (qmail 7158 invoked by uid 22791); 16 Feb 2012 00:13:41 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 16 Feb 2012 00:13:21 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1G0DKQM003499 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 15 Feb 2012 19:13:21 -0500 Received: from mesquite.lan (ovpn-113-100.phx2.redhat.com [10.3.113.100]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q1G0DKRC030433 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Wed, 15 Feb 2012 19:13:20 -0500 Date: Thu, 16 Feb 2012 00:27:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: [RFC] sim: Update sim_{fetch,store}_register for sh and mn10300 Message-ID: <20120215171319.229a3e1d@mesquite.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00316.txt.bz2 The patch below updates sim_fetch_register for both mn10300 and sh to return the length of the value being fetched instead of -1. For sh, sim_store_register() is changed in a like fashion. This change is necessary due to past changes to remote-sim.c which do more stringent checks of the return value. Comments? sim/mn10300/ChangeLog: * interp.c (sim_fetch_register): Return length, not -1. sim/ChangeLog: * sh/interp.c (sim_store_register, sim_fetch_register): Return length, not -1. Index: sim/mn10300/interp.c =================================================================== RCS file: /cvs/src/src/sim/mn10300/interp.c,v retrieving revision 1.7 diff -u -p -r1.7 interp.c --- sim/mn10300/interp.c 5 Jul 2011 19:06:38 -0000 1.7 +++ sim/mn10300/interp.c 15 Feb 2012 23:59:49 -0000 @@ -383,7 +383,7 @@ sim_fetch_register (SIM_DESC sd, int length) { put_word (memory, State.regs[rn]); - return -1; + return length; } int Index: sim/sh/interp.c =================================================================== RCS file: /cvs/src/src/sim/sh/interp.c,v retrieving revision 1.23 diff -u -p -r1.23 interp.c --- sim/sh/interp.c 16 Apr 2011 18:16:36 -0000 1.23 +++ sim/sh/interp.c 15 Feb 2012 23:59:49 -0000 @@ -2356,7 +2356,7 @@ sim_store_register (sd, rn, memory, leng default: return 0; } - return -1; + return length; } int @@ -2531,7 +2531,7 @@ sim_fetch_register (sd, rn, memory, leng return 0; } * (int *) memory = swap (val); - return -1; + return length; } int