From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29833 invoked by alias); 14 Feb 2012 18:54:24 -0000 Received: (qmail 29824 invoked by uid 22791); 14 Feb 2012 18:54:24 -0000 X-SWARE-Spam-Status: No, hits=-0.7 required=5.0 tests=AWL,BAYES_50 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Feb 2012 18:54:11 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 169591C6808; Tue, 14 Feb 2012 13:54:11 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8zV-4UZjnKw1; Tue, 14 Feb 2012 13:54:11 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B487B1C6807; Tue, 14 Feb 2012 13:54:10 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 734D6145615; Tue, 14 Feb 2012 22:53:38 +0400 (RET) Date: Tue, 14 Feb 2012 19:23:00 -0000 From: Joel Brobecker To: Aleksandar Ristovski Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] Assert when 'break' with no arguments Message-ID: <20120214185333.GB14803@adacore.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00280.txt.bz2 > ChangeLog: > 2012-02-14 Aleksandar Ristovski > > * frame.c (find_frame_sal): Initialise sal->pspace field from > frame data. > * stack.c (set_last_displayed_sal): Perform sanity check of the data > passed in, in particular, validate that PSPACE is not NULL if > requesting > valid last_displayed_* data. > > > Test suite ChangeLOg: > 2012-02-14 Aleksandar Ristovski > > * gdb.base/break-inline.exp: New test. > * gdb.base/break-inline.c: New test. I haven't looked at the validity of the patch (Pedro has a better understanding of this area, for instance), but I still noticed some trivial deviations from the GNU Coding Standards. Your ChangeLog entry, for instance. Lines should be folded at 70 chars (hard limit is 80 chars). Other violations highlighted below: > + /* Set pspace with frame's pspace */ End the sentence with a period (and two spaces before the '*/'). > + if (valid && pspace == NULL) { > + warning(_("Trying to set NULL pspace.")); > + } Wrong formatting for first and second line. > + if (valid && pspace == NULL) > + last_displayed_sal_valid = 0; Ditto for the second line (indentation is 2 spaces). > last_displayed_symtab = symtab; > last_displayed_line = line; > + > } Why are you adding an empty line here? > # Copyright 2012 Free > # Software Foundation, Inc. Missing (C), and please join the two lines. If you copied some of the testcase from another testcase, then you need to preserve the original copyright years, I think. > /* This testcase is part of GDB, the GNU debugger. > > Copyright 2012 Free Software > Foundation, Inc. Same as above, please add the missing (C). > #include > static int g; > static inline void foo(void) > { > g = 42; > printf("%d\n", g); > } > int main(int argc, char *argv[]) > { > foo(); > return g; > } Is there a way to trigger the same problem without the dependency on stdio.h? Many systems do not provide it (bareboard). I would think that all you need is to define a function that has the same profile as printf, no? -- Joel