From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13581 invoked by alias); 14 Feb 2012 14:36:25 -0000 Received: (qmail 13481 invoked by uid 22791); 14 Feb 2012 14:36:24 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Feb 2012 14:36:11 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1EEZnE9000745 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 14 Feb 2012 09:35:49 -0500 Received: from host2.jankratochvil.net (ovpn-116-26.ams2.redhat.com [10.36.116.26]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q1EEZjLq012352 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 14 Feb 2012 09:35:48 -0500 Date: Tue, 14 Feb 2012 14:36:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: Tristan Gingold , "gdb-patches@sourceware.org ml" Subject: Re: RFA: Try to include libunwind-ia64.h in libunwind-frame.h Message-ID: <20120214143545.GA22678@host2.jankratochvil.net> References: <20120210182705.GA32459@host2.jankratochvil.net> <4F3562FE.7050106@redhat.com> <20120211140919.GA24043@host2.jankratochvil.net> <4F395D17.5070303@redhat.com> <20120213190223.GA8851@host2.jankratochvil.net> <4F396251.9020409@redhat.com> <20120213192652.GA11522@host2.jankratochvil.net> <4F396CDC.7020504@redhat.com> <20120214072735.GA21362@host2.jankratochvil.net> <4F3A5001.4090500@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F3A5001.4090500@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00266.txt.bz2 On Tue, 14 Feb 2012 13:13:53 +0100, Pedro Alves wrote: > On 02/14/2012 07:27 AM, Jan Kratochvil wrote: > > the patch does not apply to HEAD, > > Huh. It did for me. I expect your MUA corrupted whitespaces: #-- head$ #++ patch$ #@ -6,7 +6,7 @@ esac],[$ enable_libunwind=yes;$ fi$ ])$ - $ +$ if test x"$enable_libunwind" = xyes; then$ AC_CHECK_HEADERS(libunwind.h libunwind-ia64.h)$ AC_DEFINE(HAVE_LIBUNWIND, 1, [Define if libunwind library is being used.])$ > > If the non-ia64 libunwind support is therefore really removed the dead code in > > libunwind-frame.c should be also removed with some comments making it ia64 > > specific. > > What dead code? At least `libunwind_frame_unwind' is dead - it has no references in the codebase - which confused me. Also when you change GDB design by this patch - from arch-independent libunwind-frame.c to ia64-limited libunwind-frame.c - one should best rename libunwind-frame.[ch] to libunwind-ia64-frame.[ch]. Otherwise at least write some comments there this file is used only for ia64 targets now. > The code is not really ia64 specific. Yes, because it was designed to be possibly used in the future with arbirary arch. Regards, Jan