From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22143 invoked by alias); 14 Feb 2012 09:02:26 -0000 Received: (qmail 22127 invoked by uid 22791); 14 Feb 2012 09:02:25 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from gbenson.demon.co.uk (HELO gbenson.demon.co.uk) (80.177.220.214) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Feb 2012 09:02:07 +0000 Date: Tue, 14 Feb 2012 09:02:00 -0000 From: Gary Benson To: gdb-patches@sourceware.org Subject: Re: [RFA take 4] Allow setting breakpoints on inline functions (PR 10738) Message-ID: <20120214090204.GA2839@redhat.com> Mail-Followup-To: gdb-patches@sourceware.org References: <20120213184700.GA31170@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00253.txt.bz2 Hi Doug, Doug Evans wrote: > On Mon, Feb 13, 2012 at 10:47 AM, Gary Benson wrote: > > Hi all, > > > > This patch makes GDB able to set breakpoints on inlined functions. > > > > This version of the patch has been updated to fix the issues Jan > > pointed out with the last version. > > > > This patch bumps the version number of the .gdb-index to 6, but > > it does not remove any of the backwards compatibility code which > > I would prefer to do as a separate patch. > > I agree support for older versions should be a separate patch. > However this patch doesn't do that (it removes current acceptance > of older versions of the index). That's correct. The older versions do not contain partial symbols for inlined functions. If GDB were to be run on a file with an older versioned index without rejecting it then the ability to set breakpoints on inlined functions would silently fail. The separate patch I was referring to would involve the removal of some extra code that is present to support version 4 indexes. For example there is a local copy of the hashing function which could be removed or could be retained depending on people's wishes. I thought it would be simpler to discuss that separately from this. Cheers, Gary -- http://gbenson.net/