From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>
Subject: [patch] Fix gdb-gdb.py for flds_bnds copy-pastes
Date: Thu, 09 Feb 2012 09:28:00 -0000 [thread overview]
Message-ID: <20120209092727.GA2664@host2.jankratochvil.net> (raw)
Hi,
one such a longstanding pain - accessing pretty-printed field name does not
work:
(gdb) p *type.main_type
$2 =
{name = 0x0,
[...]
field[0]:
########
{name = 0x2115978 "i",
[...]
bitpos = 0},
cplus_stuff = 0xf33b80}
(gdb) p/r *type.main_type
$3 = {code = TYPE_CODE_STRUCT, [...]
target_type = 0x0, flds_bnds = {fields = 0x21161f0, bounds = 0x21161f0},
####################################################
[...], func_stuff = 0xf33b80}}
(gdb) p type.main_type.field[0]
########
There is no member named field.
###############################
(gdb) p type.main_type.fields[0]
#########
There is no member named fields.
################################
(gdb) p type.main_type.flds_bnds.fields[0]
###################
$3 = {loc = {bitpos = 0, physaddr = 0, [...], name = 0x2115978 "i"}
Probably clear to check it in. I had to `print/r' to suppress gdb-gdb.py to
ba able to access GDB types fields.
Thanks,
Jan
gdb/
2012-02-09 Jan Kratochvil <jan.kratochvil@redhat.com>
* gdb-gdb.py (StructMainTypePrettyPrinter) <struct_field_img>: Print
flds_bnds.fields.
(StructMainTypePrettyPrinter) <bounds_img>: Print flds_bnds.bounds.
--- a/gdb/gdb-gdb.py
+++ b/gdb/gdb-gdb.py
@@ -166,7 +166,7 @@ class StructMainTypePrettyPrinter:
"""Return an image of the main_type field number FIELDNO.
"""
f = self.val['flds_bnds']['fields'][fieldno]
- label = "field[%d]:" % fieldno
+ label = "flds_bnds.fields[%d]:" % fieldno
if f['artificial']:
label += " (artificial)"
fields = []
@@ -186,7 +186,7 @@ class StructMainTypePrettyPrinter:
high = str(b['high'])
if b['high_undefined'] != 0:
high += " (undefined)"
- return "bounds = {%s, %s}" % (low, high)
+ return "flds_bnds.bounds = {%s, %s}" % (low, high)
def type_specific_img(self):
"""Return a string image of the main_type type_specific union.
Only the relevant component of that union is printed (based on
next reply other threads:[~2012-02-09 9:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 9:28 Jan Kratochvil [this message]
2012-02-09 9:32 ` [no-commit-intention] Naive unnamed fields for main_type [Re: [patch] Fix gdb-gdb.py for flds_bnds copy-pastes] Jan Kratochvil
2012-02-09 15:16 ` Joel Brobecker
2012-02-09 15:37 ` Jan Kratochvil
2012-02-09 18:56 ` Eli Zaretskii
2012-02-10 18:05 ` Tom Tromey
2012-02-10 19:01 ` Jan Kratochvil
2012-02-10 19:22 ` Tom Tromey
2012-02-10 19:29 ` Jan Kratochvil
2012-02-12 10:20 ` Mark Kettenis
2012-02-12 19:23 ` Jan Kratochvil
2012-02-09 19:07 ` Alfred M. Szmidt
2012-02-09 19:23 ` Stan Shebs
2012-02-10 18:07 ` Tom Tromey
2012-02-09 15:12 ` [patch] Fix gdb-gdb.py for flds_bnds copy-pastes Joel Brobecker
2012-02-09 15:15 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120209092727.GA2664@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox