Re: [PATCH] Fix breakpoint updates for multi-inferior

Pedro Alves
2012-02-08T15:47:42Z

On 02/08/2012 03:27 PM, Luis Gustavo wrote:

>> Your change makes gdb loop over all locations once for each program space.
>> How about we sort by program space in addition to address in the first place, so
>> that we'd have:
>>
>> #1 PSPACE1 ADDR1
>> #2 PSPACE1 ADDR1
>> #3 PSPACE2 ADDR1
>>
>> and things would then still work correctly with just one pass?
>>
>
> breakpoint.c:bp_location_compare (...)'s comment about keeping a stable user-visible ordering of breakpoints made me consider that solution inappropriate.
>
> Maybe i'm missing something?

We're already sorting by address first, so I'm not really sure what is
it that's user-visible that we're trying to preserve. Jan? Even if that
is still necessary, would it be ok to sort by address, then pspace, and only
after by bkpt number?

--
Pedro Alves