Re: [RFC] Add support for the Renesas rl78 architecture

Mike Frysinger
2012-01-26T02:17:35Z

[-- Attachment #1: Type: Text/Plain, Size: 542 bytes --]

On Wednesday 25 January 2012 18:58:00 Kevin Buettner wrote:
> +/* Return the register address associated with the register specified by
> + REGNO. */
> +static unsigned long reg_addr (enum sim_rl78_regnum regno)
> +{
> + if (sim_rl78_bank0_r0_regnum <= regno && regno <=
> sim_rl78_bank0_r7_regnum)
> + return 0xffef8 + (regno - sim_rl78_bank0_r0_regnum);

the if statements look funny because the operators are reversed. a more
natural (imo) check:
if (regno >= sim_rl78_bank0_r0_regnum && regno <= sim_rl78_bank0_r7_regnum)
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]