Re: [RFC] Add support for the Renesas rl78 architecture

Mike Frysinger
2012-01-26T18:28:26Z

[-- Attachment #1: Type: Text/Plain, Size: 1089 bytes --]

On Thursday 26 January 2012 02:27:04 Pedro Alves wrote:
> On 01/26/2012 02:18 AM, Mike Frysinger wrote:
> > On Wednesday 25 January 2012 18:58:00 Kevin Buettner wrote:
> >> +/* Return the register address associated with the register specified
> >> by + REGNO. */
> >> +static unsigned long reg_addr (enum sim_rl78_regnum regno)
> >> +{
> >> + if (sim_rl78_bank0_r0_regnum <= regno && regno <=
> >> sim_rl78_bank0_r7_regnum)
> >> + return 0xffef8 + (regno - sim_rl78_bank0_r0_regnum);
> >
> > the if statements look funny because the operators are reversed. a more
> >
> > natural (imo) check:
> > if (regno >= sim_rl78_bank0_r0_regnum && regno <=
> > sim_rl78_bank0_r7_regnum)
>
> Funny, I also usually go with Kevin's style. My rationale is that
>
> LOWER_RANGE <= N && N <= UPPER_RANGE
>
> looks more like the mathematical
>
> LOWER_RANGE <= N <= UPPER_RANGE
>
> and thus reads more naturally to me.

if you guys are used to it, then that's fine. not like i'm maintaining this
section of code :).

sim stuff looks OK by me
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]