From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3223 invoked by alias); 2 Feb 2012 16:51:26 -0000 Received: (qmail 3210 invoked by uid 22791); 2 Feb 2012 16:51:25 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from gbenson.demon.co.uk (HELO gbenson.demon.co.uk) (80.177.220.214) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 02 Feb 2012 16:51:02 +0000 Date: Thu, 02 Feb 2012 16:51:00 -0000 From: Gary Benson To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [RFA take 3] Allow setting breakpoints on inline functions (PR 10738) [repost] Message-ID: <20120202165059.GA12448@redhat.com> Mail-Followup-To: Jan Kratochvil , gdb-patches@sourceware.org References: <20120127151034.GA22606@redhat.com> <20120128001638.GA4448@host2.jankratochvil.net> <20120128090724.GA30170@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120128090724.GA30170@host2.jankratochvil.net> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00035.txt.bz2 Jan Kratochvil wrote: > On Fri, 27 Jan 2012 16:10:34 +0100, Gary Benson wrote: > > + > > + return cad->callback (sym, cad->data); > > + } > > + return 0; > > Could you make a comment why is here 0? I would think here should > be 1 but I may be wrong. I've been racking my brains this couple of days to remember why I set this to 0... I remember being certain it was correct, but not why, but looking at it now 1 seems right. I'm going to switch it to 1 unless I have some moment of recall. Thanks, Gary -- http://gbenson.net/