From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19830 invoked by alias); 1 Feb 2012 15:18:38 -0000 Received: (qmail 19563 invoked by uid 22791); 1 Feb 2012 15:18:36 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Feb 2012 15:18:23 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0A1C72BB00E; Wed, 1 Feb 2012 10:18:23 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id DjjKulPML4Sh; Wed, 1 Feb 2012 10:18:22 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 8B5CA2BAFBB; Wed, 1 Feb 2012 10:18:22 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id C66DB145615; Wed, 1 Feb 2012 19:18:05 +0400 (RET) Date: Wed, 01 Feb 2012 15:18:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: Performance regression (12x): Re: RFC: add relative file name handling for linespecs Message-ID: <20120201151805.GH31383@adacore.com> References: <20120119153236.GA6229@host2.jankratochvil.net> <20120201102137.GF31383@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00010.txt.bz2 > Joel> [...], but in the end, I'm just thinking I should just add the > Joel> parameter and update all callers. > > Here's the patch. Let me know what you think. I'm running regression > tests on it now, but I don't expect any problems. Thank you! > 2012-02-01 Tom Tromey > > * ada-lang.c (resolve_subexp): Update. > (ada_lookup_symbol_list): Add 'full_search' argument. > (ada_iterate_over_symbols): Pass 0 as full_search argument to > ada_lookup_symbol_list. > (ada_lookup_encoded_symbol): Update. > (get_var_value): Update. > * ada-exp.y (block_lookup): Update. > (write_var_or_type): Update. > (write_name_assoc): Update. > * ada-lang.h (ada_lookup_symbol_list): Update. This does look good to me. -- Joel