From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-87596-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25758 invoked by alias); 30 Jan 2012 15:05:23 -0000
Received: (qmail 25750 invoked by uid 22791); 30 Jan 2012 15:05:21 -0000
X-SWARE-Spam-Status: No, hits=-6.6 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Jan 2012 15:05:09 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0UF59p8010638	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Mon, 30 Jan 2012 10:05:09 -0500
Received: from host2.jankratochvil.net (ovpn-116-47.ams2.redhat.com [10.36.116.47])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q0UF52Th027680	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 30 Jan 2012 10:05:07 -0500
Date: Mon, 30 Jan 2012 16:22:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Cc: Gary Benson <gbenson@redhat.com>
Subject: Re: [RFA take 2] Linespec tweak (was: Re: [RFA take 3] Allow setting breakpoints on inline functions (PR 10738))
Message-ID: <20120130150502.GA28076@host2.jankratochvil.net>
References: <20120127151034.GA22606@redhat.com> <20120128001638.GA4448@host2.jankratochvil.net> <20120128090724.GA30170@host2.jankratochvil.net> <20120130140339.GB5210@redhat.com> <20120130141612.GA25851@host2.jankratochvil.net> <20120130145834.GD5210@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120130145834.GD5210@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-01/txt/msg00993.txt.bz2

On Mon, 30 Jan 2012 15:58:34 +0100, Gary Benson wrote:
> Updated patch attached.

It is (up to few exceptions as I see) standard in GDB rather than:
   typedef int (*symbol_found_callback_ftype) (struct symbol *sym, void *data);
to do:
   typedef int (symbol_found_callback_ftype) (struct symbol *sym, void *data);

and then everywhere change:
   			  symbol_found_callback_ftype callback,
->
   			  symbol_found_callback_ftype *callback,

It is not covered by the coding rules, though.


> Is this ok to commit?

With that change yes.


Thanks,
Jan