From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17151 invoked by alias); 30 Jan 2012 14:39:33 -0000 Received: (qmail 17139 invoked by uid 22791); 30 Jan 2012 14:39:32 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,SPF_FAIL X-Spam-Check-By: sourceware.org Received: from gbenson.demon.co.uk (HELO gbenson.demon.co.uk) (80.177.220.214) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Jan 2012 14:39:18 +0000 Date: Mon, 30 Jan 2012 14:57:00 -0000 From: Gary Benson To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Linespec tweak (was: Re: [RFA take 3] Allow setting breakpoints on inline functions (PR 10738)) Message-ID: <20120130143916.GC5210@redhat.com> Mail-Followup-To: Jan Kratochvil , gdb-patches@sourceware.org References: <20120127151034.GA22606@redhat.com> <20120128001638.GA4448@host2.jankratochvil.net> <20120128090724.GA30170@host2.jankratochvil.net> <20120130140339.GB5210@redhat.com> <20120130141612.GA25851@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120130141612.GA25851@host2.jankratochvil.net> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00990.txt.bz2 Jan Kratochvil wrote: > On Mon, 30 Jan 2012 15:03:39 +0100, Gary Benson wrote: > > Attached. I also commented the return values of another callback > > used internally by iterate_over_all_matching_symtabs, at the very > > top of the patch. > > Sorry I wrongly replied on IRC, that symbol_found_callback_ftype > should be used also for struct > language_defn->la_iterate_over_symbols and ada_iterate_over_symbols, > this was why I found it useful. Ah, that's what I initially thought you meant, but the bit about la_iterate_over_symbols being too far away made me think you wanted it in linespec.c. I'll make the change... Cheers, Gary -- http://gbenson.net/