From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17974 invoked by alias); 30 Jan 2012 11:36:44 -0000 Received: (qmail 17909 invoked by uid 22791); 30 Jan 2012 11:36:44 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Jan 2012 11:36:31 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 411F82BB1BD; Mon, 30 Jan 2012 06:36:30 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id DDqVAghL87J5; Mon, 30 Jan 2012 06:36:30 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id CEA0D2BB1BB; Mon, 30 Jan 2012 06:36:29 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id A3490145615; Mon, 30 Jan 2012 15:36:16 +0400 (RET) Date: Mon, 30 Jan 2012 11:53:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: [RFA/commit] Rename la_get_symbol_name_match_p into la_get_symbol_name_cmp Message-ID: <20120130113616.GD31383@adacore.com> References: <1327906522-19961-1-git-send-email-brobecker@adacore.com> <20120130070053.GA5994@host2.jankratochvil.net> <20120130071346.GC31383@adacore.com> <4F267E1A.7000409@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F267E1A.7000409@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00984.txt.bz2 > Did you consider keeping the name, but reverse the return logic to > be what one would expect instead (return true/false for match)? I did. But the cost is that we cannot use strcmp* as default matching routines. We end up needing a wrapper, which isn't great and also costs us an extra function call. -- Joel