From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4334 invoked by alias); 30 Jan 2012 07:01:37 -0000 Received: (qmail 4326 invoked by uid 22791); 30 Jan 2012 07:01:36 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Jan 2012 07:01:20 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0U70w1i005749 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 30 Jan 2012 02:00:58 -0500 Received: from host2.jankratochvil.net (ovpn-116-47.ams2.redhat.com [10.36.116.47]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q0U70slM003013 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 30 Jan 2012 02:00:57 -0500 Date: Mon, 30 Jan 2012 07:14:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit] Rename la_get_symbol_name_match_p into la_get_symbol_name_cmp Message-ID: <20120130070053.GA5994@host2.jankratochvil.net> References: <1327906522-19961-1-git-send-email-brobecker@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1327906522-19961-1-git-send-email-brobecker@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00980.txt.bz2 On Mon, 30 Jan 2012 07:55:22 +0100, Joel Brobecker wrote: > unless there are better naming suggestions? Maybe "la_get_symbol_name_no_match"? As you note yourself: > + Despite what the name might suggest, there is no ordering involved. > + If the names do not match, any non-zero return value is correct. > /* Implement the "la_get_symbol_name_match_p" language_defn method ^^^^^^^^^^^^^^^^^^^^^^^^^^ Forgotten unchanged string. [...] > - ada_get_symbol_name_match_p, /* la_get_symbol_name_match_p */ > + ada_get_symbol_name_cmp, /* la_get_symbol_name_match_p */ ^^^^^^^^^^^^^^^^^^^^^^^^^^ Forgotten unchanged string. I did not grep the files outside of this diff. Thanks, Jan