From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2946 invoked by alias); 27 Jan 2012 17:01:15 -0000 Received: (qmail 2922 invoked by uid 22791); 27 Jan 2012 17:01:10 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Jan 2012 17:00:53 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0RH0eev005931 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 27 Jan 2012 12:00:40 -0500 Received: from host2.jankratochvil.net (ovpn-116-47.ams2.redhat.com [10.36.116.47]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q0RH0aKk020846 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 27 Jan 2012 12:00:39 -0500 Date: Fri, 27 Jan 2012 17:09:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: Tom Tromey , gdb-patches@sourceware.org Subject: [patch] Fix the 2012-01-26 regression by la_get_symbol_name_match_p [Re: Crash regression gdb.cp/no-dmgl-verbose.exp] Message-ID: <20120127170035.GA9056@host2.jankratochvil.net> References: <20120126102148.GA24559@host2.jankratochvil.net> <20120126101635.GA24188@host2.jankratochvil.net> <20120127032004.GA3772@host2.jankratochvil.net> <20120127051509.GV31383@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120127051509.GV31383@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00954.txt.bz2 On Fri, 27 Jan 2012 06:15:09 +0100, Joel Brobecker wrote: > What if you put strcmp_iw_ordered back in the following hunk? No change. It has started to expand all the symtabs now, it is nice it at least found the bug PR symtab/13627 multiple .debug_types per objfile are not supported but it should be fixed. I will check in the patch below, it seems all the functions return strcmp-like result. No regressions on {x86_64,x86_64-m32,i686}-fedorarawhide-linux-gnu. Your patch had: ## -328,9 +339,9 @@ static int iterate_name_matcher (const struct language_defn *language, const char *name, void *d) { - const char **dname = d; + const struct symbol_matcher_data *data = d; - if (language->la_symbol_name_compare (name, *dname) == 0) + if (data->symbol_name_match_p (name, data->lookup_name)) return 1; return 0; } Thanks, Jan gdb/ 2012-01-27 Jan Kratochvil Fix the 2012-01-26 regression by la_get_symbol_name_match_p. * linespec.c (iterate_name_matcher): Negate the SYMBOL_NAME_MATCH_P result. --- a/gdb/linespec.c +++ b/gdb/linespec.c @@ -340,7 +340,7 @@ iterate_name_matcher (const char *name, void *d) { const struct symbol_matcher_data *data = d; - if (data->symbol_name_match_p (name, data->lookup_name)) + if (data->symbol_name_match_p (name, data->lookup_name) == 0) return 1; return 0; }