From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20613 invoked by alias); 27 Jan 2012 05:15:34 -0000 Received: (qmail 20598 invoked by uid 22791); 27 Jan 2012 05:15:31 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,TW_BJ X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Jan 2012 05:15:18 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BA7972BB226; Fri, 27 Jan 2012 00:15:17 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id twf8C1xttzUF; Fri, 27 Jan 2012 00:15:17 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 48DA42BB213; Fri, 27 Jan 2012 00:15:17 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id ABC99145615; Fri, 27 Jan 2012 09:15:09 +0400 (RET) Date: Fri, 27 Jan 2012 05:25:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: Crash regression gdb.cp/no-dmgl-verbose.exp: Re: [RFA 2/3] Ada: allow unqualified function names in linespecs Message-ID: <20120127051509.GV31383@adacore.com> References: <20120126102148.GA24559@host2.jankratochvil.net> <20120126101635.GA24188@host2.jankratochvil.net> <20120127032004.GA3772@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120127032004.GA3772@host2.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00934.txt.bz2 Hi Jan, > On Thu, 26 Jan 2012 11:21:48 +0100, Jan Kratochvil wrote: > > http://people.redhat.com/jkratoch/no-dmgl-verbose.o.gz > > ./gdb -nx no-dmgl-verbose.o -ex "break 'f(std::string)'" > > [...] > > Reading symbols from no-dmgl-verbose.o...done. > > Segmentation fault > > Yes, not a real regression, filed for it PR 13627:: > multiple .debug_types per objfile are not supported > http://sourceware.org/bugzilla/show_bug.cgi?id=13627 I'm trying to understand how the patch you quoted could have been triggering the problem, even if it was already a latent bug. As far as I can tell, for non-Ada units, the only difference is that I replaced a call to strcmp_iw_ordered by a call to strcmp_iw. What if you put strcmp_iw_ordered back in the following hunk? @@ -349,6 +360,13 @@ iterate_over_all_matching_symtabs (const char *name, { struct objfile *objfile; struct program_space *pspace; + struct symbol_matcher_data matcher_data; + + matcher_data.lookup_name = name; + matcher_data.symbol_name_match_p = + current_language->la_get_symbol_name_match_p != NULL + ? current_language->la_get_symbol_name_match_p (name) + : strcmp_iw; Would that mask the crash? If it did, I would *not* understand why, but that's the only change of behavior I can see from the patch. I couldn't find out much from the backtraces themselves... -- Joel