From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18222 invoked by alias); 26 Jan 2012 21:56:27 -0000 Received: (qmail 18212 invoked by uid 22791); 26 Jan 2012 21:56:26 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Jan 2012 21:56:11 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0QLtwd0001880 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 26 Jan 2012 16:55:58 -0500 Received: from host2.jankratochvil.net (ovpn-116-47.ams2.redhat.com [10.36.116.47]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q0QLtsGV024509 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 26 Jan 2012 16:55:57 -0500 Date: Thu, 26 Jan 2012 22:03:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: Pedro Alves , gdb-patches@sourceware.org, Doug Evans Subject: [commit] [patch] Do not open Python scripts twice #2 [Re: [RFC] Crash sourcing Python script on Windows] Message-ID: <20120126215553.GA7175@host2.jankratochvil.net> References: <20120123221706.GA21051@host2.jankratochvil.net> <20120124143609.GA20367@host2.jankratochvil.net> <20120124194044.GA2855@host2.jankratochvil.net> <20120124221945.GA15222@host2.jankratochvil.net> <20120125212636.GA23994@host2.jankratochvil.net> <20120126062103.GU31383@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120126062103.GU31383@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00922.txt.bz2 Hi Joel, On Thu, 26 Jan 2012 07:21:03 +0100, Joel Brobecker wrote: > The patch looks good to me and I would probably have come up with > the same sort of changes myself. I tested it on x86-windows, and > sourcing Python files still worked perfectly. I also ran it against > AdaCore's testsuite and no regression either. Thanks for the test. Checked in: http://sourceware.org/ml/gdb-cvs/2012-01/msg00219.html Sorry I did not participate in the initial review. Regards, Jan