Re: [RFC] Add support for the Renesas rl78 architecture

Kevin Buettner
2012-01-26T16:50:12Z

On Thu, 26 Jan 2012 07:27:04 +0000
Pedro Alves <palves@redhat.com> wrote:

> On 01/26/2012 02:18 AM, Mike Frysinger wrote:
> > On Wednesday 25 January 2012 18:58:00 Kevin Buettner wrote:
> >> +/* Return the register address associated with the register specified by
> >> + REGNO. */
> >> +static unsigned long reg_addr (enum sim_rl78_regnum regno)
> >> +{
> >> + if (sim_rl78_bank0_r0_regnum <= regno && regno <=
> >> sim_rl78_bank0_r7_regnum)
> >> + return 0xffef8 + (regno - sim_rl78_bank0_r0_regnum);
> >
> > the if statements look funny because the operators are reversed. a more
> > natural (imo) check:
> > if (regno >= sim_rl78_bank0_r0_regnum && regno <= sim_rl78_bank0_r7_regnum)
>
> Funny, I also usually go with Kevin's style. My rationale is that
>
> LOWER_RANGE <= N && N <= UPPER_RANGE
>
> looks more like the mathematical
>
> LOWER_RANGE <= N <= UPPER_RANGE
>
> and thus reads more naturally to me.

Yep, that's my rationale too. :)

> While we're at it, can we put the function name at column 0? :-)

Oops. Thanks for catching that.

Yes, I'll fix that, make the corrections that Joel suggested, and then
post a follow up.

Thanks to everyone who's looked at it so far!

Kevin