From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9736 invoked by alias); 26 Jan 2012 04:23:19 -0000 Received: (qmail 9726 invoked by uid 22791); 26 Jan 2012 04:23:18 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Jan 2012 04:23:05 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0F05E2BB3C3; Wed, 25 Jan 2012 23:23:05 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id i5+qbAfds6iX; Wed, 25 Jan 2012 23:23:04 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9CB8C2BB3BD; Wed, 25 Jan 2012 23:23:04 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 95F25145615; Thu, 26 Jan 2012 08:22:58 +0400 (RET) Date: Thu, 26 Jan 2012 04:23:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 2/3] Ada: allow unqualified function names in linespecs Message-ID: <20120126042258.GR31383@adacore.com> References: <20111221140128.GK23376@adacore.com> <1324636693-24034-3-git-send-email-brobecker@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00885.txt.bz2 > Joel> This is the meat, where we replace the old la_symbol_name_compare > Joel> language method with the new ada_get_symbol_name_match_p. > Joel> It fixes the problem when trying to insert a breakpoint on "+". > > This looks ok to me. Thanks, Tom! I re-tested and checked the patch in. -- Joel