From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13047 invoked by alias); 26 Jan 2012 02:17:35 -0000 Received: (qmail 13038 invoked by uid 22791); 26 Jan 2012 02:17:34 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,TW_XF,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Jan 2012 02:17:21 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 8203A1B4011; Thu, 26 Jan 2012 02:17:20 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: Re: [RFC] Add support for the Renesas rl78 architecture Date: Thu, 26 Jan 2012 02:24:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.2.0; KDE/4.6.5; x86_64; ; ) Cc: Kevin Buettner References: <20120125165800.5351c291@mesquite.lan> In-Reply-To: <20120125165800.5351c291@mesquite.lan> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4127901.4NryPQhrt8"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201201252118.06928.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00883.txt.bz2 --nextPart4127901.4NryPQhrt8 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-length: 542 On Wednesday 25 January 2012 18:58:00 Kevin Buettner wrote: > +/* Return the register address associated with the register specified by > + REGNO. */ > +static unsigned long reg_addr (enum sim_rl78_regnum regno) > +{ > + if (sim_rl78_bank0_r0_regnum <= regno && regno <= > sim_rl78_bank0_r7_regnum) > + return 0xffef8 + (regno - sim_rl78_bank0_r0_regnum); the if statements look funny because the operators are reversed. a more natural (imo) check: if (regno >= sim_rl78_bank0_r0_regnum && regno <= sim_rl78_bank0_r7_regnum) -mike --nextPart4127901.4NryPQhrt8 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJPILfeAAoJEEFjO5/oN/WBN4UP/3s4FLw8MRx6muojc0wCqDby PJS5UFr7CRsFgO0lha0qMIWm0jaA4VV6ghaTlOaJZxXttFTA4dBmXWPFXXw0B22p 6dAsFOtKO1pbZuSvkFdD4acQjYi8cBQN2WRHcRDJAcRk1KSkKWISQMn6dFWBNmQn oomqRs7py4OF0mX3r2xi1kWnyWRARGUIa+XO49pCye2+KnPOye/03kvVPWGcB0oJ E2pY00RxgWojCuQ77ZDvKkzEnQdnrB022rjKvY08M6ueDzldp7bkh9oa0xM+1Pzr yaKVkdEoV4GKa4ToGCmfK7yze3p4PZngNfXugQyuPC23ASH1VR8vrL+6dIU+pBhW quLq4C2BXOYF4UUUOH6DRXDeXk0I9J6G34+0FNBix9i6BFogBhV0BCrCOw180B3C lYmg2taFozAcD884r9grlywXepnnqi2/4RTuDNw1oXAzA6+2Nnn58FU+fcE2879O e62+/UqiCRkyVYEi0oJmhFjHyP1O1sjBB2wY76pX3yaEwj6GLlGV0nT6PIApRgVL vYxt4+nVTIbKuAWHi7b0BhflFRg1X33WCLf9W4gSaKxrv9vNfENwelP85Tnq4Flg VnH689xlS3A1eI5/Q4+z7Mey1TfHNNfYFLN4drFPuoljXIit3COMpfeqfAn+KpQT mYroDyAe4HNt1nsz1qb6 =r9LN -----END PGP SIGNATURE----- --nextPart4127901.4NryPQhrt8--