From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: palves@redhat.com (Pedro Alves)
Cc: gdb-patches@sourceware.org (GDB Patches)
Subject: Re: Distinguish target and "fake" PID values in extended-remote's "run", and when connecting in non-stop mode too.
Date: Tue, 24 Jan 2012 13:53:00 -0000 [thread overview]
Message-ID: <201201241340.q0ODe13R019726@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <4F1DBBA7.2060507@redhat.com> from "Pedro Alves" at Jan 23, 2012 07:57:27 PM
Pedro Alves wrote:
> Here's the promised fix. Non-stop's thread/inferior discovery on connection also
> needed to be handled. I've made sure "info proc" would complain when the multiprocess
> extensions were off, with extended-remote/run, and also with plain remote + non-stop, and
> would operate on the currect process otherwise. I've ran the testsuite against
> local gdbserver, and no regressions showed up. I also ran the testsuite with
> multiprocess extensions off, and the only regressions were caused by core file
> generation no longer working, which was expected.
>
> I've simplified the code that was previously put in a bit while factoring it
> out to the new add_current_inferior_and_thread function, avoiding the
> ptid_build ugliness.
>
> Comments?
Looks good to me.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2012-01-24 13:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 20:27 Pedro Alves
2012-01-24 13:53 ` Ulrich Weigand [this message]
2012-01-24 14:36 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201241340.q0ODe13R019726@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox