From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19303 invoked by alias); 23 Jan 2012 22:17:44 -0000 Received: (qmail 19293 invoked by uid 22791); 23 Jan 2012 22:17:44 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Jan 2012 22:17:25 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0NMHBlL011400 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 23 Jan 2012 17:17:11 -0500 Received: from host2.jankratochvil.net (ovpn-116-21.ams2.redhat.com [10.36.116.21]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q0NMH7RI020013 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 23 Jan 2012 17:17:09 -0500 Date: Mon, 23 Jan 2012 22:47:00 -0000 From: Jan Kratochvil To: Doug Evans Cc: Pedro Alves , Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [patch] Do not open Python scripts twice #2 [Re: [RFC] Crash sourcing Python script on Windows] Message-ID: <20120123221706.GA21051@host2.jankratochvil.net> References: <1317251996-12146-1-git-send-email-brobecker@adacore.com> <20120123181125.GA26683@host2.jankratochvil.net> <4F1DA92A.4020207@redhat.com> <20120123210850.GA28792@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00798.txt.bz2 Hello Doug, On Mon, 23 Jan 2012 22:59:58 +0100, Doug Evans wrote: > Do you have any data that shows there is a problem with the double opening? Native GNU/Linux application would never double open files. It is the similar reason I disable GDB directories relocation in Fedora - as it is not a normal native application behavior - and in some corner cases it even breaks execution. GDB is still a bit exotic codebase nowadays, there is a long way to make it a normal application with codebase for easy contributions: http://sourceware.org/gdb/wiki/ProjectIdeas Here are some specific internal cleanups that are worth doing: > [I'm kinda uncomfortable with this patch, as is.] I am uncomfortable with code opening file by filename I have already an opened FILE * for, that is IMNSHO a clear bug. But sure if there is consensus it cannot be fixed in FSF GDB I can move the fix to Fedora GDB, there is now already ~50 to-be-merged patches. Thanks, Jan