From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14946 invoked by alias); 19 Jan 2012 16:24:19 -0000 Received: (qmail 14933 invoked by uid 22791); 19 Jan 2012 16:24:16 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 Jan 2012 16:23:56 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0JGNsn3004524 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 19 Jan 2012 11:23:54 -0500 Received: from host2.jankratochvil.net (ovpn-116-21.ams2.redhat.com [10.36.116.21]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q0JGNnKm009727 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 19 Jan 2012 11:23:52 -0500 Date: Thu, 19 Jan 2012 16:27:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org, Tom Tromey , Kevin Pouget Subject: Re: Call target_close after unpushing, not before (was: Re: [patch] Fix remote.c crash on gdbserver close (+fix py-finish-breakpoint.exp for gdbserver)) Message-ID: <20120119162349.GA8115@host2.jankratochvil.net> References: <20111225113745.GA16273@host2.jankratochvil.net> <20111227232323.GA6956@host2.jankratochvil.net> <4F020A20.2020801@gmail.com> <4F183E97.4010704@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F183E97.4010704@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00703.txt.bz2 On Thu, 19 Jan 2012 17:02:31 +0100, Pedro Alves wrote: > Any comments on this? I am fine with it with the comment update. Thanks, Jan gdb/ 2012-01-19 Jan Kratochvil * target.h (target_close): Update comment on the target's unpush state. --- a/gdb/target.h +++ b/gdb/target.h @@ -820,10 +820,10 @@ extern struct target_ops current_target; longer going to be calling. QUITTING indicates that GDB is exiting and should not get hung on an error (otherwise it is important to perform clean termination, even if it takes a while). This routine - is automatically always called when popping the target off the - target stack (to_beneath is undefined). Closing file descriptors - and freeing all memory allocated memory are typical things it - should do. */ + is automatically always called after popping the target off the + target stack - the target's own methods are no longer available + through the target vector. Closing file descriptors and freeing all + memory allocated memory are typical things it should do. */ void target_close (struct target_ops *targ, int quitting);