Performance regression (12x): Re: RFC: add relative file name handling for linespecs

Jan Kratochvil
2012-01-19T15:33:03Z

Hi Tom,

I have noticed nightly regression testing to start randomly timing out a lot
for gdb.ada/* testcases, narrowed it down to this check-in.

The failures are not reproducible standalone but they happen during the heavy
nigly load, still the testcase runtime is proving enough something is wrong.

Thanks,
Jan

On Mon, 16 Jan 2012 21:40:05 +0100, Tom Tromey wrote:
> Here is the version I am checking in.

commit 024e0e8b29c57131c65424b31e931e6f8f511248
Author: Tom Tromey <tromey@redhat.com>
Date: Mon Jan 16 20:40:47 2012 +0000

gdb
* NEWS: Add item.
* symtab.h (compare_filenames_for_search): Declare.
* symtab.c (compare_filenames_for_search): New function.
(iterate_over_some_symtabs): Use it.
* symfile.h (struct quick_symbol_functions)
<map_symtabs_matching_filename>: Change spec.
* psymtab.c (partial_map_symtabs_matching_filename): Use
compare_filenames_for_search. Update for new spec.
* dwarf2read.c (dw2_map_symtabs_matching_filename): Use
compare_filenames_for_search. Update for new spec.
* breakpoint.c (clear_command): Use compare_filenames_for_search.
gdb/doc
* gdb.texinfo (Specify Location): Document relative file name
handling.
gdb/testsuite
* gdb.linespec/linespec.exp: Change some tests to use $decimal.
Add tests for relative directory.

sync;time runtest gdb.ada/tasks.exp
024e0e8b29c57131c65424b31e931e6f8f511248 0m6.412s
eb28de4a09f016d3de7caccec781eb70995a4001 0m0.538s