Re: Performance regression (12x): Re: RFC: add relative file name handling for linespecs

Tom Tromey
2012-02-01T15:04:02Z

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> I missed this message! You should have told me and I would have looked
Joel> into it.

Oh, sure, now you tell me ;-)

Joel> Thanks a lot for the patch. I agree that the patch looks correct,
Joel> but I'm a little confused by the name of the new function (the _full
Joel> suffix suggests that the lookup is always a full search).

Joel> Traditionally, we've used a _1 suffix instead, which is very
Joel> unimaginative and yet so convenient. I was going to change
Joel> your patch this way, but in the end, I'm just thinking I should
Joel> just add the parameter and update all callers. There are not that
Joel> many. I suspect you might have thought about this too, only to
Joel> just try the minimum change.

Joel> Would it be OK with you if I made that change instead?

I will do it, it is no big deal.

Tom