From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26309 invoked by alias); 18 Jan 2012 16:50:14 -0000 Received: (qmail 26295 invoked by uid 22791); 18 Jan 2012 16:50:10 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Jan 2012 16:49:57 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8A4B42BB01B; Wed, 18 Jan 2012 11:49:56 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Jh9FyJ2ag43g; Wed, 18 Jan 2012 11:49:56 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1DD152BAFFD; Wed, 18 Jan 2012 11:49:56 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 5C46F145615; Wed, 18 Jan 2012 20:49:17 +0400 (RET) Date: Wed, 18 Jan 2012 17:03:00 -0000 From: Joel Brobecker To: Michael Eager Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH] PowerPC 32 with Secure PLT Message-ID: <20120118164917.GD31383@adacore.com> References: <4F163E35.1080505@eagerm.com> <20120118120831.GB31383@adacore.com> <4F16E632.6010102@eagerm.com> <4F16F527.2000800@eagerm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F16F527.2000800@eagerm.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00673.txt.bz2 > >>This is an area where I am not sure, but I think it would be better > >>to use read_memory_typed_address. I think the address type that you > >>want is: builtin_type (gdbarch)->builtin_func_ptr. > > I think I'd rather leave the size explicit, rather than making > it indirect (and unclear). This routine is only for PowerPC 32 and > the size of the value is always four bytes. That would be fine with me. You should be able to get rid of the cast, though. No? -- Joel