From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16089 invoked by alias); 16 Jan 2012 17:28:50 -0000 Received: (qmail 16080 invoked by uid 22791); 16 Jan 2012 17:28:50 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e06smtp14.uk.ibm.com (HELO e06smtp14.uk.ibm.com) (195.75.94.110) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Jan 2012 17:28:37 +0000 Received: from /spool/local by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 16 Jan 2012 17:28:36 -0000 Received: from d06nrmr1407.portsmouth.uk.ibm.com ([9.149.38.185]) by e06smtp14.uk.ibm.com ([192.168.101.144]) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 16 Jan 2012 17:28:34 -0000 Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1407.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q0GHSYB22322676 for ; Mon, 16 Jan 2012 17:28:34 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q0GHSXBY024299 for ; Mon, 16 Jan 2012 10:28:33 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id q0GHSW4D024277; Mon, 16 Jan 2012 10:28:32 -0700 Message-Id: <201201161728.q0GHSW4D024277@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 16 Jan 2012 18:28:32 +0100 Subject: Re: [rfc v2][0/6] Remote /proc file access To: palves@redhat.com (Pedro Alves) Date: Mon, 16 Jan 2012 18:27:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <4F14446F.3060704@redhat.com> from "Pedro Alves" at Jan 16, 2012 03:38:23 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit x-cbid: 12011617-1948-0000-0000-000000A6E128 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00560.txt.bz2 Pedro Alves wrote: > I've been through the series, and it looks good to me. > Thanks a lot! If this doesn't work out in the end, I'll certainly help > sort it out. Thanks for the review! > I've given a couple comments in reply to the patches directly. I'm leaving > some general-ish comments here: > > - We could consider making "info proc" work with the default run > target if the current target can't handle it, so that > "info proc PID" works even when not debugging a process yet, > like today. Maybe. On the other hand, once we've switched to the gdbarch based implementation, it would automatically work when not yet debugging a process anyway, so I'm not sure this is really necessary ... > - It could be argued that the pid parsing should be kept at > the target/gdbarch callbacks side (pass down `char *args'), > so that we didn't have: > > + if (args && *args == '/') > + tid = strtoul (args + 1, &args, 10); > + else > + tid = 0; > > in infcmd.c:info_proc_cmd_1 which is only needed by procfs.c. Yes, good point. In fact, that makes more sense; the format of a process ID ought to be target-specific (like with attach). Also, this will make the diffs a bit smaller ... I'll provide an updated patch set. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com