From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Cleanup: pass "-pie" only to the linker
Date: Fri, 13 Jan 2012 18:42:00 -0000 [thread overview]
Message-ID: <20120113182844.GA29277@host2.jankratochvil.net> (raw)
In-Reply-To: <20120113165503.02937190B08@elbrus2.mtv.corp.google.com>
On Fri, 13 Jan 2012 17:55:02 +0100, Paul Pluzhnikov wrote:
> -set opts [list debug {additional_flags=-fPIE -pie}]
> +set opts [list debug {"additional_flags=-fPIE" "ldflags=-pie"}]
> if {[build_executable ${testfile}.exp $executable1 $srcfile [concat $opts {additional_flags=-DBIN=1}]] == ""
> || [build_executable ${testfile}.exp $executable2 $srcfile [concat $opts {additional_flags=-DBIN=2}]] == ""} {
The first change is OK but this one is wrong, you have disabled -pie
completely from gdb.log when you check it. {...} will include the literal
text into the variable, including quoting in this case.
It should be best:
set opts [list debug additional_flags=-fPIE ldflags=-pie]
as no quotes are needed anymore (as there is no space). There could be also:
set opts [list debug "additional_flags=-fPIE" "ldflags=-pie"]
but those quotes are just not needed there.
OK to check it in with that change.
Thanks,
Jan
next prev parent reply other threads:[~2012-01-13 18:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 17:02 Paul Pluzhnikov
2012-01-13 18:42 ` Jan Kratochvil [this message]
2012-01-13 19:59 ` Paul Pluzhnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120113182844.GA29277@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox