Re: [rfc v2][4/6] Readlink as file I/O target operation

Eli Zaretskii
2012-01-13T18:28:53Z

> Date: Fri, 13 Jan 2012 19:15:12 +0100 (CET)
> From: "Ulrich Weigand" <uweigand@de.ibm.com>
>
> --- gdb-head.orig/gdb/doc/gdb.texinfo 2012-01-13 18:44:34.000000000 +0100
> +++ gdb-head/gdb/doc/gdb.texinfo 2012-01-13 18:45:57.000000000 +0100
> @@ -17450,6 +17450,10 @@ are:
> @tab @code{vFile:unlink}
> @tab @code{remote delete}
>
> +@item @code{hostio-readlink-packet}
> +@tab @code{vFile:readlink}
> +@tab Host I/O
> +
> @item @code{noack-packet}
> @tab @code{QStartNoAckMode}
> @tab Packet acknowledgment
> @@ -36193,6 +36197,16 @@ error occurred.
> Delete the file at @var{pathname} on the target. Return 0,
> or -1 if an error occurs. @var{pathname} is a string.
>
> +@item vFile:readlink: @var{pathname}
> +Read value of symbolic link @var{pathname} on the target. Return
> +the number of bytes read, or -1 if an error occurs.
> +
> +The data read should be returned as a binary attachment on success.
> +If zero bytes were read, the response should include an empty binary
> +attachment (i.e.@: a trailing semicolon). The return value is the
> +number of target bytes read; the binary attachment may be longer if
> +some characters were escaped.
> +

This part is okay, but please don't use "pathname" when you really
mean "file name". GNU Coding Standards frown on using "path" or its
derivatives for anything but PATH-style directory lists.

Thanks.