From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26851 invoked by alias); 13 Jan 2012 17:02:49 -0000 Received: (qmail 26842 invoked by uid 22791); 13 Jan 2012 17:02:47 -0000 X-SWARE-Spam-Status: No, hits=-0.1 required=5.0 tests=AWL,BAYES_00,SPF_FAIL,TO_NO_BRKTS_DIRECT X-Spam-Check-By: sourceware.org Received: from gbenson.demon.co.uk (HELO gbenson.demon.co.uk) (80.177.220.214) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Jan 2012 17:02:32 +0000 Date: Fri, 13 Jan 2012 17:09:00 -0000 From: Gary Benson To: gdb-patches@sourceware.org Subject: RFC: remove "info catch" Message-ID: <20120113170229.GA32071@redhat.com> Mail-Followup-To: gdb-patches@sourceware.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="FL5UXtIhxfXey3p5" Content-Disposition: inline X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00486.txt.bz2 --FL5UXtIhxfXey3p5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 229 Hi all, While poking around in the blockvector code I noticed that the command "info catch" has been disabled (with #if 1...else) since December 2007. This patch removes it. Ok to commit? Cheers, Gary -- http://gbenson.net/ --FL5UXtIhxfXey3p5 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="info-catch.patch" Content-length: 7587 diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 1a96f26..e86357f 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,11 @@ +2012-01-13 Gary Benson + + Delete #if 0'd out code. + * stack.c (print_frame_label_vars): Remove. + (catch_info): Likewise. + (_initialize_stack): Remove "info catch" command. + * NEWS: Mention the above. + 2012-01-12 Jan Kratochvil * configure: Regenerate. diff --git a/gdb/NEWS b/gdb/NEWS index a9a7859..24c12b6 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -9,6 +9,9 @@ * The binary "gdbtui" can no longer be built or installed. Use "gdb -tui" instead. +* The command "info catch" has been removed. It has been disabled + since December 2007. + *** Changes in GDB 7.4 * GDB now handles ambiguous linespecs more consistently; the existing diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index 2914190..852d551 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,3 +1,8 @@ +2012-01-13 Gary Benson + + Delete #if 0'd out code. + * gdb.texinfo (Frame Info): Remove "info catch". + 2012-01-11 Paul Hilfinger * gdb.texinfo (Variables): Document use of :: for non-static diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 4a8ff7b..fc4d03b 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -6339,16 +6339,6 @@ Print the local variables of the selected frame, each on a separate line. These are all variables (declared either static or automatic) accessible at the point of execution of the selected frame. -@kindex info catch -@cindex catch exceptions, list active handlers -@cindex exception handlers, how to list -@item info catch -Print a list of all the exception handlers that are active in the -current stack frame at the current point of execution. To see other -exception handlers, visit the associated frame (using the @code{up}, -@code{down}, or @code{frame} commands); then type @code{info catch}. -@xref{Set Catchpoints, , Setting Catchpoints}. - @end table diff --git a/gdb/stack.c b/gdb/stack.c index b15b5fc..6536d74 100644 --- a/gdb/stack.c +++ b/gdb/stack.c @@ -1968,82 +1968,6 @@ print_frame_local_vars (struct frame_info *frame, int num_tabs, fprintf_filtered (stream, _("No locals.\n")); } -/* Same, but print labels. */ - -static void -print_frame_label_vars (struct frame_info *frame, int this_level_only, - struct ui_file *stream) -{ -#if 1 - fprintf_filtered (stream, "print_frame_label_vars disabled.\n"); -#else - struct blockvector *bl; - struct block *block = get_frame_block (frame, 0); - struct gdbarch *gdbarch = get_frame_arch (frame); - int values_printed = 0; - int index, have_default = 0; - char *blocks_printed; - CORE_ADDR pc = get_frame_pc (frame); - - if (block == 0) - { - fprintf_filtered (stream, "No symbol table info available.\n"); - return; - } - - bl = blockvector_for_pc (BLOCK_END (block) - 4, &index); - blocks_printed = alloca (BLOCKVECTOR_NBLOCKS (bl) * sizeof (char)); - memset (blocks_printed, 0, BLOCKVECTOR_NBLOCKS (bl) * sizeof (char)); - - while (block != 0) - { - CORE_ADDR end = BLOCK_END (block) - 4; - int last_index; - - if (bl != blockvector_for_pc (end, &index)) - error (_("blockvector blotch")); - if (BLOCKVECTOR_BLOCK (bl, index) != block) - error (_("blockvector botch")); - last_index = BLOCKVECTOR_NBLOCKS (bl); - index += 1; - - /* Don't print out blocks that have gone by. */ - while (index < last_index - && BLOCK_END (BLOCKVECTOR_BLOCK (bl, index)) < pc) - index++; - - while (index < last_index - && BLOCK_END (BLOCKVECTOR_BLOCK (bl, index)) < end) - { - if (blocks_printed[index] == 0) - { - if (print_block_frame_labels (gdbarch, - BLOCKVECTOR_BLOCK (bl, index), - &have_default, stream)) - values_printed = 1; - blocks_printed[index] = 1; - } - index++; - } - if (have_default) - return; - if (values_printed && this_level_only) - return; - - /* After handling the function's top-level block, stop. Don't - continue to its superblock, the block of per-file symbols. - Also do not continue to the containing function of an inlined - function. */ - if (BLOCK_FUNCTION (block)) - break; - block = BLOCK_SUPERBLOCK (block); - } - - if (!values_printed && !this_level_only) - fprintf_filtered (stream, _("No catches.\n")); -#endif -} - void locals_info (char *args, int from_tty) { @@ -2051,14 +1975,6 @@ locals_info (char *args, int from_tty) 0, gdb_stdout); } -static void -catch_info (char *ignore, int from_tty) -{ - /* Assume g++ compiled code; old GDB 4.16 behaviour. */ - print_frame_label_vars (get_selected_frame (_("No frame selected.")), - 0, gdb_stdout); -} - /* Iterate over all the argument variables in block B. Returns 1 if any argument was walked; 0 otherwise. */ @@ -2615,9 +2531,6 @@ Usage: T \n")); Select the stack frame that contains .\n\ Usage: func \n")); - add_info ("catch", catch_info, - _("Exceptions that can be caught in the current stack frame.")); - add_setshow_enum_cmd ("frame-arguments", class_stack, print_frame_arguments_choices, &print_frame_arguments, _("Set printing of non-scalar frame arguments"), diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index fa4141e..3f79136 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,10 @@ +2012-01-13 Gary Benson + + Delete #if 0'd out code. + * gdb.base/default.exp (info catch): Remove. + * gdb.base/gdb_history (info catch): Likewise. + * gdb.base/help.exp (info catch): Likewise. + 2012-01-12 Keith Seitz PR mi/10586 diff --git a/gdb/testsuite/gdb.base/default.exp b/gdb/testsuite/gdb.base/default.exp index 9677396..d0a8295 100644 --- a/gdb/testsuite/gdb.base/default.exp +++ b/gdb/testsuite/gdb.base/default.exp @@ -282,8 +282,6 @@ gdb_test "info args" "No frame selected." "info args" gdb_test "info bogus-gdb-command" "Undefined info command: \"bogus-gdb-command\". Try \"help info\".*" "info bogus-gdb-command" #test info breakpoints gdb_test "info breakpoints" "No breakpoints or watchpoints." "info breakpoints" -#test info catch -gdb_test "info catch" "No frame selected." "info catch" #test info copying # FIXME -- doesn't work worth a shit #send_gdb "info copying" diff --git a/gdb/testsuite/gdb.base/gdb_history b/gdb/testsuite/gdb.base/gdb_history index cc22f69..231ba33 100644 --- a/gdb/testsuite/gdb.base/gdb_history +++ b/gdb/testsuite/gdb.base/gdb_history @@ -85,7 +85,6 @@ info all-registers info args info bogus-gdb-command info breakpoints -info catch info copying info display info f diff --git a/gdb/testsuite/gdb.base/help.exp b/gdb/testsuite/gdb.base/help.exp index 819643d..117e5b5 100644 --- a/gdb/testsuite/gdb.base/help.exp +++ b/gdb/testsuite/gdb.base/help.exp @@ -240,8 +240,6 @@ gdb_test "help info args" "Argument variables of current stack frame\." "help in gdb_test "help info breakpoints" \ "Status of specified breakpoints .all user-settable breakpoints if no argument.*\[\r\n\]+breakpoint set\." \ "help info breakpoints" -# test help info catch -gdb_test "help info catch" "Exceptions that can be caught in the current stack frame\." "help info catch" # test help info copying gdb_test "help info copying" "Conditions for redistributing copies of GDB\." "help info copying" # test help info display --FL5UXtIhxfXey3p5--