Re: [patch] Fix for PR gdb/9538 (loading of separate debuginfo and symlinks).

Doug Evans
2012-01-12T23:28:57Z

On Thu, Jan 12, 2012 at 3:25 PM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> On Fri, 13 Jan 2012 00:17:55 +0100, Doug Evans wrote:
>> OOC, Jan, what discussion led rise to having braces here:
>
> There was only Mark's agreement with me as I read now:
>        Re: Code formatting [Re: [patch] s390*: watchpoints regression [repost]]
>        http://sourceware.org/ml/gdb-patches/2011-12/msg00600.html
>
> So still not sure what is the general consensus.

Thanks.
I think we should make the braces required.

>> and does that reasoning apply here:
>>
>> +  if (debuglink == NULL)
>> +    /* There's no separate debug info, hence there's no way we could
>> +       load it => no warning.  */
>> +    return NULL;
>
> There exist already many cases in GDB not compliant with this rule.

Yeah. Asking for it is a start.

>
>
> Regards,
> Jan