From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29633 invoked by alias); 11 Jan 2012 09:05:28 -0000 Received: (qmail 29625 invoked by uid 22791); 11 Jan 2012 09:05:27 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Jan 2012 09:05:14 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 66F9F2BB1E5; Wed, 11 Jan 2012 04:05:10 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id DxDkOuM96ISq; Wed, 11 Jan 2012 04:05:10 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id F1F402BB1E4; Wed, 11 Jan 2012 04:05:09 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 212FF145615; Wed, 11 Jan 2012 13:04:46 +0400 (RET) Date: Wed, 11 Jan 2012 09:06:00 -0000 From: Joel Brobecker To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [patch] dwarf2read.c: Don't read pc/line-number mapping for type units Message-ID: <20120111090446.GH31383@adacore.com> References: <20120110014616.957501E25C7@ruffy2.mtv.corp.google.com> <20120110035113.GA31383@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00344.txt.bz2 > Appended is what I committed to trunk. > I think it's fine. [...] > The memory space reduction is substantial so I'd like to get this in 7.4. > [the reduction only kicks in for .debug_types, btw] > > 2012-01-10 Doug Evans > > * dwarf2read.c (dwarf_decode_lines): Remove arg "abfd". New arg > "want_line_info". All callers updated. > (dwarf_decode_lines_1): New function. > (handle_DW_AT_stmt_list): Add function comment. > New arg "want_line_info". All callers updated. > (read_file_scope,read_type_unit_scope): Move comment from > handle_DW_AT_stmt_list to here. If the gain is substantial, and you think it's fine, then no objection on my end. -- Joel