From: Joel Brobecker <brobecker@adacore.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] dwarf2read.c: Don't read pc/line-number mapping for type units
Date: Tue, 10 Jan 2012 03:55:00 -0000 [thread overview]
Message-ID: <20120110035113.GA31383@adacore.com> (raw)
In-Reply-To: <20120110014616.957501E25C7@ruffy2.mtv.corp.google.com>
> Type units don't need the pc/line-number mapping,
> and this can save a lot of space.
Types in general have a sloc, and we sometimes use them. For instance,
trying the following:
(gdb) ptype ambiguous_type
Multiple matches for ambiguous_type
[0] cancel
[1] pck.ambiguous_type at pck.adb:8
[2] bar.ambiguous_type at bar.adb:9
>
Is your patch going to affect the above?
> Joel: I'd also like to check this into the 7.4 branch.
> IMO it's safe enough.
No problem on my end if the concerns above are unfounded.
Although I know I do not know this file as well as you do.
--
Joel
next prev parent reply other threads:[~2012-01-10 3:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 3:51 Doug Evans
2012-01-10 1:46 ` Doug Evans
2012-01-10 3:55 ` Joel Brobecker [this message]
2012-01-10 21:46 ` Doug Evans
2012-01-11 9:06 ` Joel Brobecker
2012-01-11 19:24 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120110035113.GA31383@adacore.com \
--to=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox