Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Ulrich Weigand <uweigand@de.ibm.com>,
	       Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: [revert] Regression on PowerPC (Re: [patch] Fix gdb.cp/gdb2495.exp regression with gcc-4.7 #3)
Date: Wed, 04 Jan 2012 14:01:00 -0000	[thread overview]
Message-ID: <20120104140104.GA22254@host2.jankratochvil.net> (raw)
In-Reply-To: <20120103155206.GM2730@adacore.com> <201201031444.q03Eir77009359@d06av02.portsmouth.uk.ibm.com>

On Tue, 03 Jan 2012 15:44:53 +0100, Ulrich Weigand wrote:
> This seems to have caused
> 
> FAIL: gdb.cp/gdb2495.exp: Call a function that raises an exception without a handler. (timeout)

Thanks for catching it.


> Switching to the ON_STACK method fixes this for me.  But I'm not sure
> if there are other platforms beside PowerPC that have the same problem ...
> Maybe we ought to default to ON_STACK (at least on Linux?)?

Both AT_ENTRY_POINT solutions have some problems so I agree it is better to
keep it as is before some complete fix is implemented.  Reverted my patch:
	http://sourceware.org/ml/gdb-cvs/2012-01/msg00042.html
and reverted it also from 7.4:
	http://sourceware.org/ml/gdb-cvs/2012-01/msg00043.html

In fact the whole issue isn't so serious (exception thrown out of infcall).


> Maybe there should be a default implementation based on
> gdbarch_inner_than/gdbarch_frame_align_p and the breakpoint length?

I will return to it in some time.


On Tue, 03 Jan 2012 16:52:06 +0100, Joel Brobecker wrote:
> It seems to me, at this point, that indeed the best way to solve
> the original problem is to transition the GNU/Linux platforms to
> ON_STACK.

I agree, I am no longer aware how to solve it without depending on the stack
space.


Sorry,
Jan


  parent reply	other threads:[~2012-01-04 14:01 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-22 20:49 [patch] Fix gdb.cp/gdb2495.exp regression with gcc-4.7 Jan Kratochvil
2011-12-27  6:23 ` Joel Brobecker
2011-12-28 16:30   ` Jan Kratochvil
2011-12-28 18:47     ` [patch] Fix gdb.cp/gdb2495.exp regression with gcc-4.7 #2 Jan Kratochvil
2011-12-28 20:40       ` Mark Kettenis
2011-12-30  2:45         ` [patch] Fix gdb.cp/gdb2495.exp regression with gcc-4.7 #3 Jan Kratochvil
2011-12-30  8:46           ` Joel Brobecker
2011-12-30 11:11             ` Mark Kettenis
2011-12-30 14:16               ` Jan Kratochvil
2011-12-31  2:56               ` Peter Schauer
2011-12-30 11:25             ` Jan Kratochvil
2012-01-01 22:22               ` Jan Kratochvil
2012-01-02  2:45                 ` Joel Brobecker
2012-01-02  2:58                   ` Jan Kratochvil
2012-01-03 14:45                     ` Regression on PowerPC (Re: [patch] Fix gdb.cp/gdb2495.exp regression with gcc-4.7 #3) Ulrich Weigand
2012-01-03 15:52                       ` Joel Brobecker
2012-01-04 14:01                       ` Jan Kratochvil [this message]
2012-01-04 14:09                         ` [revert] " Joel Brobecker
2012-03-08 23:24                         ` [patch] Fix gdb.cp/gdb2495.exp regression with gcc-4.7 #4 [Re: [revert] Regression on PowerPC] Jan Kratochvil
2012-03-09  7:22                           ` cancel: " Jan Kratochvil
2012-01-02 14:10 ` [patch] Fix gdb.cp/gdb2495.exp regression with gcc-4.7 Pedro Alves
2012-01-02 14:20   ` Jan Kratochvil
2012-01-02 14:44     ` Pedro Alves
2012-01-02 14:53       ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120104140104.GA22254@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox