From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30252 invoked by alias); 3 Jan 2012 18:44:53 -0000 Received: (qmail 30238 invoked by uid 22791); 3 Jan 2012 18:44:52 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e06smtp14.uk.ibm.com (HELO e06smtp14.uk.ibm.com) (195.75.94.110) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 03 Jan 2012 18:44:39 +0000 Received: from /spool/local by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 3 Jan 2012 18:44:28 -0000 Received: from d06nrmr1407.portsmouth.uk.ibm.com ([9.149.38.185]) by e06smtp14.uk.ibm.com ([192.168.101.144]) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 3 Jan 2012 18:44:25 -0000 Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1407.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q03IiOQ02240592 for ; Tue, 3 Jan 2012 18:44:24 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q03IiOKO001290 for ; Tue, 3 Jan 2012 11:44:24 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id q03IiMwV001269; Tue, 3 Jan 2012 11:44:23 -0700 Message-Id: <201201031844.q03IiMwV001269@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 03 Jan 2012 19:44:22 +0100 Subject: Re: [RFA] Ignore data minimal symbols for breakpoint linespecs To: brobecker@adacore.com (Joel Brobecker) Date: Tue, 03 Jan 2012 18:44:00 -0000 From: "Ulrich Weigand" Cc: emachado@linux.vnet.ibm.com (Edjunior Barbosa Machado), mark.kettenis@xs4all.nl (Mark Kettenis), gdb-patches@sourceware.org In-Reply-To: <20111228151541.GM23376@adacore.com> from "Joel Brobecker" at Dec 28, 2011 07:15:41 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit x-cbid: 12010318-1948-0000-0000-0000008BA84E Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00106.txt.bz2 Joel Brobecker wrote: > > excellent, I've tested it on ppc64 and it fixes all those regressions > > I mentioned. > > Excellent. It would be nice to have someone else's feedback before > I commit, as I am not very familiar with this sort of thing (I tend > to have a simpler view of things, as the first patch demonstrated). I was seeing the same regressions on ppc64, and the patch indeed fixes them. I'm wondering whether this is best place to perform this check, though -- maybe it might be better to label function descriptor minsyms as mst_text to start with (or possibly some new category) ... But in the absence of such a solution, I'd still be in favor of committing your patch as is, given that it fixes a serious regression and doesn't look like it can make things worse. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com