From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6269 invoked by alias); 29 Dec 2011 04:11:43 -0000 Received: (qmail 5211 invoked by uid 22791); 29 Dec 2011 04:11:41 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Dec 2011 04:11:28 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3A5A42BB198; Wed, 28 Dec 2011 23:11:28 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id mcLh8GMzsr8X; Wed, 28 Dec 2011 23:11:28 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A790C2BB184; Wed, 28 Dec 2011 23:11:27 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 41B41145615; Wed, 28 Dec 2011 20:11:11 -0800 (PST) Date: Thu, 29 Dec 2011 05:17:00 -0000 From: Joel Brobecker To: Doug Evans Cc: gdb-patches@sourceware.org, iant@google.com Subject: Re: [RFC] Initial pass at supporting the Go language Message-ID: <20111229041111.GR23376@adacore.com> References: <20111228210206.B6B762461C9@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111228210206.B6B762461C9@ruffy.mtv.corp.google.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00885.txt.bz2 > This patch is a first pass at supporting the Go language. > There's still lots to do, but this is a start. I quickly skimmed through the patch, particularly the changes in GDB. I like how you've nicely and consistently documented your code. From the comments, I can see that you have a feature that is similar to what we have in Ada, namely to be able to use the unqualified name of an entity. For instance, if you have a variable foo in package bar, you want to be able to write either, you want to be able to use either "print bar" or "print foo.bar". If that's correct, it's interesting how you decided to side-step the problem (assuming I understood your changes correctly). (I even noticed that Ada is mentioned somewhere - didn't try to understand why, though). Just a tiny thing that sort of caught my attention while flash forwarding the testing part of your code (nice number of tests!). > +# Start with a fresh gdb. > + > +gdb_exit > +gdb_start > +gdb_reinitialize_dir $srcdir/$subdir Use clean_restart? Clearly a fair amount of work has already gone into that port. I'm impressed. -- Joel