From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11713 invoked by alias); 27 Dec 2011 12:40:36 -0000 Received: (qmail 11697 invoked by uid 22791); 27 Dec 2011 12:40:35 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Dec 2011 12:40:21 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id F22082BADF7; Tue, 27 Dec 2011 07:40:20 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id MC71ojzrR1wZ; Tue, 27 Dec 2011 07:40:20 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 73EDC2BAB2D; Tue, 27 Dec 2011 07:40:20 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 8D1A4145615; Tue, 27 Dec 2011 04:40:09 -0800 (PST) Date: Tue, 27 Dec 2011 13:47:00 -0000 From: Joel Brobecker To: asmwarrior Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit] Improve gdb_realpath for Windows hosts Message-ID: <20111227124009.GG23376@adacore.com> References: <1324574084-7971-1-git-send-email-brobecker@adacore.com> <4EF9B94C.7030204@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4EF9B94C.7030204@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00839.txt.bz2 > Someone said that "MAX_PATH" is not enough about several months ago > when we were discussing some breakpoint issue see: > http://sourceware.org/ml/gdb/2011-06/msg00101.html My understanding is: - The way this function is called, its output is limited to MAX_PATH; - If the canonialized path does in fact exceed MAX_PATH, then the canonicalization fails, and we fallback on the old way (strdup). So I do not see the problem with the current approach. There might be a better implementation, allowing longer paths, but this is already better than before. And if there is a better implementation indeed, it does need to work on all supported versions of Windows (I think we need to support at least as back as XP, possibly older). -- Joel