From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10197 invoked by alias); 23 Dec 2011 11:01:59 -0000 Received: (qmail 10186 invoked by uid 22791); 23 Dec 2011 11:01:56 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 23 Dec 2011 11:01:37 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 98CE62BB1D3; Fri, 23 Dec 2011 06:01:36 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Mvj6uDHr3jt6; Fri, 23 Dec 2011 06:01:36 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 248052BB1B2; Fri, 23 Dec 2011 06:01:36 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id B9D6D145615; Fri, 23 Dec 2011 03:01:26 -0800 (PST) Date: Fri, 23 Dec 2011 11:03:00 -0000 From: Joel Brobecker To: Tom Tromey , Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Ignore data minimal symbols for breakpoint linespecs Message-ID: <20111223110126.GX23376@adacore.com> References: <1324548943-26819-1-git-send-email-brobecker@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1324548943-26819-1-git-send-email-brobecker@adacore.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00805.txt.bz2 > This patch fixes regressions that showed up gdb.ada/task_bp.exp. > > FAIL: gdb.ada/task_bp.exp: break pck.dummy_task - from psymtab > FAIL: gdb.ada/task_bp.exp: break pck.dummy_task - from full symtab This patch also happen to fix the gdb.base/fixsection.exp regression reported by Jan :-). (http://www.sourceware.org/ml/gdb-patches/2011-12/msg00560.html) -PASS: gdb.base/fixsection.exp: breakpoint at static_fun +FAIL: gdb.base/fixsection.exp: breakpoint at static_fun It's exactly the same problem: You have a data symbol named static_fun inside the minimal symbol table of fixsectshr.sl. After having found all symbols from the debugging info, GDB searched the minimal symbol tables and found that data symbol too. (gdb) b static_fun Breakpoint 2 at 0x4005fc: static_fun. (2 locations) (gdb) info break Num Type Disp Enb Address What 2 breakpoint keep y 2.1 y 0x00000000004005fc in static_fun at /[...]/fixsection.c:26 2.2 y 0x00007ffff7dde798 (gdb) info symbol 0x00007ffff7dde798 static_fun in section .bss of /[...]/fixsectshr.sl > gdb/ChangeLog: > > * linespec.c (struct collect_minsyms) [list_mode]: New field. > (add_minsym): Ignore data symbols if not in list mode. > (search_minsyms_for_name): Set local.list_mode. > > gdb/testsuite/ChangeLog: > > * gdb.base/dmsym.c, gdb.base/dmsym_main.c, gdb.base/dmsym.exp: > New files. -- Joel