Re: [patch 1/2] Drop gdbtui [+doc changes]

Eli Zaretskii
2011-12-22T08:05:00Z

> Date: Wed, 21 Dec 2011 23:35:23 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>, "'Joel Brobecker'" <brobecker@adacore.com>, gdb-patches@sourceware.org, "'Sergio Durigan'" <sdurigan@redhat.com>, "'Kai Tietz'" <ktietz@redhat.com>
>
> On Wed, 21 Dec 2011 18:25:28 +0100, Tom Tromey wrote:
> > >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> >
> > Jan> I understand the Joel's proposal as dropping gdbtui entirely and
> > Jan> everywhere, so that users will notice it.
> >
> > It would be fine by me.
>
> Here it is.

Thanks. I have a couple of comments.

> -version of @value{GDBN}, e.g., @command{gdbtui}, to run.
> +version of @value{GDBN}, e.g., @command{gdb -tui}, to run.

@command is for names of commands, not for command lines. Please use
@samp here.

> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -6,6 +6,8 @@
> * GDBserver now supports stdio connections.
> E.g. (gdb) target remote | ssh myhost gdbserver - hello
>
> +* The binary "gdbtui" has been removed. Use "gdb -tui" instead.
> +

I think the first sentence should say

The binary "gdbtui" is no longer built or installed.

because we didn't really "remove" anything ;-)

Thanks.