Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: jan.kratochvil@redhat.com (Jan Kratochvil)
Cc: gdb-patches@sourceware.org
Subject: Re: [commit, s390] Fix regression in gdb.base/callfuncs.exp [Re: [commit, s390] Proper handling of PSW address/mask everywhere]
Date: Wed, 21 Dec 2011 19:41:00 -0000	[thread overview]
Message-ID: <201112211937.pBLJbGUQ019925@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <20111219225612.GA29085@host2.jankratochvil.net> from "Jan Kratochvil" at Dec 19, 2011 11:56:12 PM

Jan Kratochvil wrote:
> On Mon, 19 Dec 2011 22:49:16 +0100, Ulrich Weigand wrote:
> > Tested with no regression (fixing the callfuncs.exp one) on s390x (-m31,-m64).
> > Committed to mainline and 7.4 branch.
> 
> Confirming it works, thanks.
> 
> There are yet some regressions of sigstep.exp, I will check them more:

Hmm, I'm not seeing this particular symptom you mention below.

However, I did see failures on old kernels in 31-bit compat mode only;
it turned out these were caused by a kernel bug that is exposed by my
GDB change.

When the kernel sets up the registers for calling a signal handler,
it is supposed to place the return address including the addressing
mode bit into register %r14.  This does in fact happen in native
31-bit mode.  However, in 31-bit compat mode under a 64-bit kernel,
the addressing mode bit was not set.  This has been fixed at least
for regular signal handlers in current git (note that RT signals
are still broken).

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  reply	other threads:[~2011-12-21 19:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-30 16:10 [commit, s390] Proper handling of PSW address/mask everywhere Ulrich Weigand
2011-12-19 19:58 ` Regression gdb.base/callfuncs.exp for s390-on-s390x [Re: [commit, s390] Proper handling of PSW address/mask everywhere] Jan Kratochvil
2011-12-19 22:39   ` [commit, s390] Fix regression in gdb.base/callfuncs.exp " Ulrich Weigand
2011-12-20  4:28     ` Jan Kratochvil
2011-12-21 19:41       ` Ulrich Weigand [this message]
2011-12-21 20:47         ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201112211937.pBLJbGUQ019925@d06av02.portsmouth.uk.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox