From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18521 invoked by alias); 21 Dec 2011 06:52:52 -0000 Received: (qmail 18505 invoked by uid 22791); 21 Dec 2011 06:52:51 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Dec 2011 06:52:36 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BB5492BB278; Wed, 21 Dec 2011 01:52:35 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id GPadRuak9pfS; Wed, 21 Dec 2011 01:52:35 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 519412BB277; Wed, 21 Dec 2011 01:52:35 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 598B2145615; Tue, 20 Dec 2011 22:52:24 -0800 (PST) Date: Wed, 21 Dec 2011 07:16:00 -0000 From: Joel Brobecker To: Kevin Pouget Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFC] Python Finish Breakpoints Message-ID: <20111221065224.GA4120@adacore.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00709.txt.bz2 > Great! I'll fix this last bits and commit it in the next few days > Is it okay for 7.4 branch as well ? Tom asked me on IRC whether it would be OK for 7.4 as well, with some doubts on his side. With the time difference, I wasn't there anymore, so I thought I'd answer here. As always, if a Global Maintainer (such as Tom) is confident about a given patch, that's always good enough for me to put it in. I'm not sure whether Tom was asking me to look at the patch and make an evaluation myself. I skimmed the patch, and at first sight, it seems big, and slightly intrusive (in the sense that it touches several files, many of them critical to all platforms). My initial impression, which would need a more careful read of your patch to be confirmed, is that it might be a little risky to do so. Tom: Just let me know if you'd like me to look at the patch more in detail. -- Joel