From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8942 invoked by alias); 19 Dec 2011 22:39:59 -0000 Received: (qmail 8921 invoked by uid 22791); 19 Dec 2011 22:39:58 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_BJ X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Dec 2011 22:39:34 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pBJMdI03019021 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 19 Dec 2011 17:39:18 -0500 Received: from host2.jankratochvil.net (ovpn-116-60.ams2.redhat.com [10.36.116.60]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pBJMdD6v014366 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 19 Dec 2011 17:39:16 -0500 Date: Mon, 19 Dec 2011 22:56:00 -0000 From: Jan Kratochvil To: Ulrich Weigand Cc: Tom Tromey , gdb-patches@sourceware.org, Joel Brobecker , Pedro Alves Subject: [commit+7.4] [patch+7.4] reread.exp 7.3->7.4 regression Message-ID: <20111219223913.GA9603@host2.jankratochvil.net> References: <20111219191201.GA7401@host2.jankratochvil.net> <201112192137.pBJLb4UZ026021@d06av02.portsmouth.uk.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201112192137.pBJLb4UZ026021@d06av02.portsmouth.uk.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00654.txt.bz2 On Mon, 19 Dec 2011 22:37:04 +0100, Ulrich Weigand wrote: > > No regressions on {x86_64,x86_64-m32,i686}-fedora16-linux-gnu and on > > arm-fedora13beta-linux-gnu. OK to check it in and for 7.4? > > > > gdb/ > > 2011-12-19 Jan Kratochvil > > > > * symfile.c (reread_symbols): Move free_objfile_separate_debug, > > preserve_values, sym_finish and clear_objfile_data calls before BFD > > close. Move free_objfile_separate_debug as the very first call. New > > comment on the ordering. > > This looks reasonable to me, and seems preferable to the ARM-specific hack ... Checked in and for 7.4: http://sourceware.org/ml/gdb-cvs/2011-12/msg00197.html http://sourceware.org/ml/gdb-cvs/2011-12/msg00198.html Thanks for the review, Jan