Re: [patch+7.4] reread.exp 7.3->7.4 regression

Tom Tromey
2011-12-19T19:05:16Z

>>>>> "Ulrich" == Ulrich Weigand <uweigand@de.ibm.com> writes:

Ulrich> I really think this ought to be fixed in reread_symbols; freeing the old
Ulrich> OBFD needs to be done *after* all the callbacks to cleanup objfile data
Ulrich> have completed.

I agree.

Also see free_objfile, which calls objfile_free_data before closing the
BFD.

This, btw, is the main reason that I like Jan's old patch to unify
re-reading with freeing -- it automatically means consistency.

Perhaps Pedro's problems with that patch could be alleviated by having
"destroy in place" and "initialize in place" functions that both
free_objfile and reread_symbols could use.

Tom