From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16113 invoked by alias); 19 Dec 2011 21:37:24 -0000 Received: (qmail 16104 invoked by uid 22791); 19 Dec 2011 21:37:23 -0000 X-SWARE-Spam-Status: No, hits=-3.0 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,RP_MATCHES_RCVD,TW_BJ X-Spam-Check-By: sourceware.org Received: from e06smtp16.uk.ibm.com (HELO e06smtp16.uk.ibm.com) (195.75.94.112) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Dec 2011 21:37:10 +0000 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 19 Dec 2011 21:37:08 -0000 Received: from d06nrmr1407.portsmouth.uk.ibm.com ([9.149.38.185]) by e06smtp16.uk.ibm.com ([192.168.101.146]) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 19 Dec 2011 21:37:06 -0000 Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1407.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pBJLb5Wv2277476 for ; Mon, 19 Dec 2011 21:37:05 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pBJLb5sv026073 for ; Mon, 19 Dec 2011 14:37:05 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id pBJLb4UZ026021; Mon, 19 Dec 2011 14:37:04 -0700 Message-Id: <201112192137.pBJLb4UZ026021@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 19 Dec 2011 22:37:04 +0100 Subject: Re: [patch+7.4] reread.exp 7.3->7.4 regression To: jan.kratochvil@redhat.com (Jan Kratochvil) Date: Mon, 19 Dec 2011 21:49:00 -0000 From: "Ulrich Weigand" Cc: tromey@redhat.com (Tom Tromey), gdb-patches@sourceware.org, brobecker@adacore.com (Joel Brobecker), alves.ped@gmail.com (Pedro Alves) In-Reply-To: <20111219191201.GA7401@host2.jankratochvil.net> from "Jan Kratochvil" at Dec 19, 2011 08:12:01 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit x-cbid: 11121921-3548-0000-0000-00000074696F Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00652.txt.bz2 Jan Kratochvil wrote: > On Mon, 19 Dec 2011 11:30:54 +0100, Ulrich Weigand wrote: > > I can test on ARM if you want. > > I have tested it on fedora13beta. Just on > > Hardware : OMAP3 Beagle Board > Revision : 0020 > Processor : ARMv7 Processor rev 2 (v7l) > BogoMIPS : 506.27 > > it takes 57m28.760s to build GDB (although with full symbols) and 51m13.889s > to run the testsuite, is it normal to develop on ARM with this performance? I guess so. A Panda is a bit faster than the Beagle, but still ... > > Your initial patch already moved the callbacks calls up a bit; > > My patch was using free_objfile, I do not understand which patch of mine do > you refer to now. > Re: [patch] Replace reread_symbols by load+free calls > http://sourceware.org/ml/gdb-patches/2009-06/msg00696.html Sorry, I was refering to the first patch in list you had in the mail I replied to. Specifically, I was talking about this patch: http://sourceware.org/ml/gdb-patches/2009-06/msg00606.html which seems to have gone upstream 2009-06-23. > > In addition, we should probably call observer_notify_new_objfile so that new > > tables can be built up for the re-read file ... > > I can post it afterwards, that is probably not for 7.4, I will have to run the > ARM testsuite again. OK, thanks. > No regressions on {x86_64,x86_64-m32,i686}-fedora16-linux-gnu and on > arm-fedora13beta-linux-gnu. OK to check it in and for 7.4? > > gdb/ > 2011-12-19 Jan Kratochvil > > * symfile.c (reread_symbols): Move free_objfile_separate_debug, > preserve_values, sym_finish and clear_objfile_data calls before BFD > close. Move free_objfile_separate_debug as the very first call. New > comment on the ordering. This looks reasonable to me, and seems preferable to the ARM-specific hack ... Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com