From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10896 invoked by alias); 19 Dec 2011 10:50:47 -0000 Received: (qmail 10879 invoked by uid 22791); 19 Dec 2011 10:50:45 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Dec 2011 10:50:29 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pBJAo5cn023551 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 19 Dec 2011 05:50:05 -0500 Received: from host2.jankratochvil.net (ovpn-116-60.ams2.redhat.com [10.36.116.60]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pBJAnxG0031960 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 19 Dec 2011 05:50:02 -0500 Date: Mon, 19 Dec 2011 11:16:00 -0000 From: Jan Kratochvil To: Eli Zaretskii Cc: dje@google.com, brobecker@adacore.com, tromey@redhat.com, gdb-patches@sourceware.org Subject: Re: [doc patch] gdbint: XFAIL vs. KFAIL [Re: [patch] gcc KFAILs to XFAILs] Message-ID: <20111219104959.GA8788@host2.jankratochvil.net> References: <20111209215319.GA5132@host2.jankratochvil.net> <20111210160145.GA7261@host2.jankratochvil.net> <20111211024742.GN21915@adacore.com> <20111211092552.GA14574@host2.jankratochvil.net> <20111211124213.GO21915@adacore.com> <20111214185650.GA8485@host2.jankratochvil.net> <20111214194220.GA24281@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00633.txt.bz2 On Thu, 15 Dec 2011 06:21:46 +0100, Eli Zaretskii wrote: > > +Known problem of @value{GDBN} itself. You must specify the @value{GDBN} bug > > +report number. > > Regarding the "must specify the bug report number": would it make > sense to show how to do that, e.g. with an example? Is this OK for check-in? Thanks, Jan gdb/doc/ 2011-12-19 Jan Kratochvil * gdbint.texinfo (Testsuite): Describe KFAIL and XFAIL in Writing tests. --- a/gdb/doc/gdbint.texinfo +++ b/gdb/doc/gdbint.texinfo @@ -7846,6 +7846,45 @@ instance, some @value{GDBN} bugs involving the display of source lines would never manifest themselves if the programs used GNU coding style uniformly. +Some testcase results need more detailed explanation: + +@table @code +@item KFAIL +Known problem of @value{GDBN} itself. You must specify the @value{GDBN} bug +report number like in these sample tests: +@smallexample +kfail "gdb/13392" "continue to marker 2" +@end smallexample +or +@smallexample +setup_kfail gdb/13392 "*-*-*" +kfail "continue to marker 2" +@end smallexample + +@item XFAIL +Known problem of environment. This typically includes @value{NGCC} but it +includes also many other system components which cannot be fixed in the +@value{GDBN} project. Sample test with sanity check not knowing the specific +cause of the problem: +@smallexample +# On x86_64 it is commonly about 4MB. +if @{$stub_size > 25000000@} @{ + xfail "stub size $stub_size is too large" + return +@} +@end smallexample + +You should provide bug report number for the failing component of the +environment, if such bug report is available: +@smallexample +if @{[test_compiler_info @{gcc-[0-3]-*@}] + || [test_compiler_info @{gcc-4-[0-5]-*@}]@} @{ + setup_xfail "gcc/46955" *-*-* +@} +gdb_test "python print ttype.template_argument(2)" "&C::c" +@end smallexample +@end table + @node Hints @chapter Hints