From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6232 invoked by alias); 19 Dec 2011 08:13:48 -0000 Received: (qmail 6217 invoked by uid 22791); 19 Dec 2011 08:13:46 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Dec 2011 08:13:31 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1FFD62BB37B; Mon, 19 Dec 2011 03:13:31 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id abjittF+XUMW; Mon, 19 Dec 2011 03:13:31 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 911D82BB37A; Mon, 19 Dec 2011 03:13:30 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id D421E145615; Mon, 19 Dec 2011 00:13:21 -0800 (PST) Date: Mon, 19 Dec 2011 09:32:00 -0000 From: Joel Brobecker To: Yao Qi Cc: Jan Kratochvil , Hui Zhu , gdb-patches ml Subject: Re: [obv] Fix unused-but-set-variable error [Re: [OB] Fix linux-low.c build error] Message-ID: <20111219081321.GS21915@adacore.com> References: <20111218192239.GA25401@host2.jankratochvil.net> <20111218205826.GA15385@host2.jankratochvil.net> <4EEED8FB.4040103@codesourcery.com> <20111219065002.GQ21915@adacore.com> <4EEEEE57.90901@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4EEEEE57.90901@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00626.txt.bz2 > This native socket is used for synchronization between gdbserver and > libinproctrace.so agent. gdbserver puts command into cmd_buf, writes > one byte in socket to notify gdb_ust_thread (a dedicated thread) and > wait. gdb_ust_thread picks up command from cmd_buf. When process is > done, gdb_ust_thread writes one byte again to notify gdbserver and close > socket. I don't think we have to do something w.r.t write failure. The > description above is quite user-invisible, so a warning may confuse > users to some extent, IMO. Sounds good to me. But wouldn't a comment in the code be useful? It's probably obvious to you today, but it might not be to someone else, or even to you in a couple of years from now... -- Joel