Re: [patch] s390*: watchpoints regression [repost]

Jan Kratochvil
2011-12-17T20:35:29Z

On Sat, 17 Dec 2011 21:12:57 +0100, Pedro Alves wrote:
> On Saturday 17 December 2011 19:56:32, Pedro Alves wrote:
> > Hmm. I'm starting to think that the easiest is jut to
> > go back at not calling new_thread for the first thread.
> > Let me give that a try.
>
> Seems to work fine. This should obsolete the s390 patch.

I can confirm it fixes both the x86* DR set for wrapper and the s390
regression.

> --- a/gdb/linux-nat.c
> +++ b/gdb/linux-nat.c
> @@ -1151,7 +1151,7 @@ add_lwp (ptid_t ptid)
> lp->next = lwp_list;
> lwp_list = lp;
>
> - if (linux_nat_new_thread != NULL)
> + if (num_lwps (GET_PID (ptid)) > 1 && linux_nat_new_thread != NULL)
> linux_nat_new_thread (lp);
>
> return lp;

After this regression churn and all the discussion around I believe this line
is worth some comment, like I wrote in the previous s390* patch. That
num_lwps there is very magic.

Thanks,
Jan