Re: [patch] s390*: watchpoints regression [repost]

Jan Kratochvil
2011-12-18T09:59:36Z

On Sun, 18 Dec 2011 07:21:27 +0100, Joel Brobecker wrote:
> > + /* This is the main thread still going through the shell, or, no
> > + watchpoint has been set yet. */
> > + if (lwp->arch_private == NULL)
> > + return;
>
> Just a really minor nitpick: Would you consider putting the comment
> inside the if, instead of just before? I think it'd be slightly clearer
> that way.

FYI I am aware of this rule and I try to follow it but it seems unnatural to
me. It then requires new { brackets } and when reading the code I would more
expect to see why the conditional happens, not why the return happens.

But no problem continuing to follow this rule.

Thanks,
Jan